Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make functions part of alloc_layout_extra (#55724) const. #99016

Closed
wants to merge 1 commit into from
Closed

Make functions part of alloc_layout_extra (#55724) const. #99016

wants to merge 1 commit into from

Conversation

Raekye
Copy link
Contributor

@Raekye Raekye commented Jul 7, 2022

Make functions part of alloc_layout_extra (#55724) const. Requires two additional feature flags: const_alloc_layout and const_try (from my understanding std already builds with many other nightly features). I added them in alphabetical order. The only implementation change is std::cmp::max has to be replaced with an explicit if expression since trait methods are not const.

@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2022
@Raekye
Copy link
Contributor Author

Raekye commented Jul 7, 2022

@rustbot label +T-libs-api -T-libs

I think that is correct?

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 7, 2022
@CAD97
Copy link
Contributor

CAD97 commented Jul 8, 2022

Even though the changes look trivial, I recommend roll-up=iffy on this PR because seemingly noöp changes to the layout code have caused perf regressions before.

@bors
Copy link
Contributor

bors commented Jul 13, 2022

☔ The latest upstream changes (presumably #99136) made this pull request unmergeable. Please resolve the merge conflicts.

@thomcc
Copy link
Member

thomcc commented Jul 16, 2022

Hi, this is an API change and so needs to go through the ACP process, as described by the bot:

If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already.

@thomcc thomcc added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2022
@Raekye Raekye mentioned this pull request Aug 31, 2022
Closed
@JohnCSimon JohnCSimon added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Sep 11, 2022
@JohnCSimon
Copy link
Member

triage: adding blocked tag
rust-lang/libs-team#94

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2022
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 10, 2022
@pitaj
Copy link
Contributor

pitaj commented Jan 29, 2023

@rustbot label +S-waiting-on-ACP

@rustbot rustbot added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Jan 29, 2023
@Raekye
Copy link
Contributor Author

Raekye commented Mar 30, 2023

The constification of these methods has been merged in the (later submitted) PR #102207

@Raekye Raekye closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Raekye @rustbot @rust-highfive @CAD97 @bors @thomcc @JohnCSimon @pitaj @Dylan-DPC